【Bug-Fix】 Fix compile bug of cudaxxxAsync in put_along_axis #60934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
changed the title
YibinLiu666
reviewed
Jan 18, 2024
| cudaMemsetAsync(shared_mem, 0, sizeof(int) * grad_size, stream); | ||
| int64_t grid_memset = (grad_size + block - 1) / block; | ||
| CudaMemsetAsync<<<grid_memset, block, 0, stream>>>( | ||
| shared_mem + grad_size, 1, sizeof(int) * grad_size); |
There was a problem hiding this comment.
求mean的梯度的时候元素个数初始化为1，也就是后面的shared_mem + grad_size部分，这里好像没有设置为1
|
其他地方应该没有啥问题了。然后非常感谢研发大哥帮忙修bug（服务器的网挂了，拉不下submodule，给您磕一个 |
zhwesky2010
force-pushed
the
fix_bug1
branch
2 times, most recently
from
5ef490b
to
77a804f
Compare
|
LGTM，麻烦研发大哥了 |
zhwesky2010
changed the title
zhwesky2010
added a commit
to zhwesky2010/Paddle
that referenced
this pull request
Feb 26, 2024
zhwesky2010
changed the title
zhwesky2010
changed the title
XiaoguangHu01
pushed a commit
that referenced
this pull request
Feb 28, 2024
* 【Hackathon 5th No.6】 为 Paddle 增强put_along_axis API -part (#59674) * fix bug of put_along_axis (#60551) * Improve the performence of put_along_axis (#60618) * fix bug of put_along_axis * improve performence of put_along_axis * [Bug-Fix] fix compile bug of cudaxxxAsync (#60934) --------- Co-authored-by: YibLiu <68105073+YibinLiu666@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Description
card-79490
解决 #60673 的问题，修复 #60551 引入的编译Bug