-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【paddle_test No.31、32】replace cc_test with paddle_test #60959
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
86f909f
to
aff6342
Compare
13600f8
to
02d0a62
Compare
@luotao1 @risemeup1 @Galaxy1458 麻烦各位佬看一下这个windows ci为啥没过,触发好几次都没有通过 |
HI,paddle_test()这个方法原则上不需要DEPS,除非是DEPS在test阶段产生(往往以test_, _tester等开头或结尾),在这个PR中,出现了符号重定义问题,是因为重复链接库所导致,所有paddle_test()的所有DEPS都需删除。可了解下[cmake治理]删除paddle_test多余无用依赖任务 |
2d7a230
to
01d6d98
Compare
@Galaxy1458 在windows上,这个flags_native_test的UT,如果不去掉paddle_flags依赖,会出现重链接库的现象,如果去掉,会出现unresolved external symbol,我这边没有windows环境可以测试,请问这个依赖该怎么添加呢,是需要修改代码吗? |
6590cb3
to
8828368
Compare
PR types
Others
PR changes
Others
Description
#60793