Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize index put preprocess #61060

Merged

Conversation

zoooo0820
Copy link
Contributor

PR types

Performance optimization

PR changes

Others

Description

Pcard-66985

Optimize the preprocess cost of index_put op by check if there is bool-index and reducing operators of vector.

Copy link

paddle-bot bot commented Jan 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zoooo0820 zoooo0820 changed the title Optimize index put preprocess2 Optimize index put preprocess Jan 23, 2024
@zoooo0820 zoooo0820 marked this pull request as draft January 23, 2024 11:10
@zoooo0820 zoooo0820 marked this pull request as ready for review January 23, 2024 11:10
@zoooo0820 zoooo0820 marked this pull request as draft January 23, 2024 11:11
@zoooo0820 zoooo0820 marked this pull request as ready for review January 23, 2024 11:11
@zoooo0820 zoooo0820 marked this pull request as draft January 24, 2024 02:48
@zoooo0820 zoooo0820 marked this pull request as ready for review January 24, 2024 02:48
@zoooo0820 zoooo0820 force-pushed the optimize_index_put_preprocess2 branch from 3407011 to 46b2488 Compare January 24, 2024 02:50
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit dc7ef7e into PaddlePaddle:develop Jan 25, 2024
29 of 30 checks passed
@zoooo0820 zoooo0820 deleted the optimize_index_put_preprocess2 branch January 25, 2024 03:24
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
* reduce vector operations when no bool index

* reduce vector in index_put

* reduce vector operations

* no change for value
zoooo0820 added a commit to zoooo0820/Paddle that referenced this pull request Feb 27, 2024
* reduce vector operations when no bool index

* reduce vector in index_put

* reduce vector operations

* no change for value
zoooo0820 added a commit to zoooo0820/Paddle that referenced this pull request Feb 27, 2024
* reduce vector operations when no bool index

* reduce vector in index_put

* reduce vector operations

* no change for value
XiaoguangHu01 pushed a commit that referenced this pull request Feb 28, 2024
* tensor_array slice in PIR (#60503)

* use slice_array, now will meet error of destory opresult still in use

* disable the pir test until the bug fixed

* Optimize advanced setting by remove the last set_value (#60771)

* pure-advanced setitem will not set_value back

* fix multi output in tensor_array_pir

* only in dynamic mode

* add only advanced-setting case to fix coverage

* fast pass for bool setitem (#61021)

* fast pass for bool setitem

* fix 0-size value case

* remove final set_value OP in combined-indexing setting (#60983)

* remove setvalue in combined indexing set

* using combined-setting case to test

* Optimize index put preprocess (#61060)

* reduce vector operations when no bool index

* reduce vector in index_put

* reduce vector operations

* no change for value

* fix shape error in combine-getitem (#61922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants