Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] fix security problem for prune_by_memory_estimation #61320

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[Security] fix security problem for prune_by_memory_estimation #61320

merged 2 commits into from
Jan 30, 2024

Conversation

vn-ncvinh
Copy link
Contributor

PR types

Others

PR changes

Others

Description

fix security problem for prune_by_memory_estimation

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 29, 2024
@luotao1
Copy link
Contributor

luotao1 commented Jan 30, 2024

Please fix the CodeStyle problem
image

Caozhou1995
Caozhou1995 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Caozhou1995 Caozhou1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ForFishes
ForFishes approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit bd70057 into PaddlePaddle:develop Jan 30, 2024
29 of 30 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Jan 30, 2024

@vn-ncvinh Could you cherry-pick to release/2.6?

@vn-ncvinh
Copy link
Contributor Author

@vn-ncvinh Could you cherry-pick to release/2.6?

Thank you for your instruction. Would you prefer me to handle the cherry-picking myself, or would you like to take care of it?

@luotao1
Copy link
Contributor

luotao1 commented Jan 31, 2024

We prefer you to handle the cherry-picking yourself.

@luotao1 luotao1 mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caozhou1995 Caozhou1995 Caozhou1995 left review comments

@ForFishes ForFishes ForFishes approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vn-ncvinh @CLAassistant @luotao1 @ForFishes @Caozhou1995 @wanghuancoder