Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the iOS build doc #6180

Closed
wants to merge 1 commit into from

Conversation

wangkuiyi
Copy link
Collaborator

No description provided.

Copy link

@kavyasrinet kavyasrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Once merged, I can create another PR with a final polishing.

@@ -18,37 +18,19 @@ PaddlePaddle为交叉编译提供了工具链配置文档[cmake/cross_compiling/

- `CMAKE_SYSTEM_NAME`,CMake编译的目标平台,必须设置为`iOS`。在设置`CMAKE_SYSTEM_NAME=iOS`后,PaddlePaddle的CMake系统会自动编译所有的第三方依赖库,并且强制设置一些PaddlePaddle参数的值(`WITH_C_API=ON`、`WITH_GPU=OFF`、`WITH_AVX=OFF`、`WITH_PYTHON=OFF`、`WITH_RDMA=OFF`)。
- `WITH_C_API`,是否编译C-API预测库,必须设置为ON。在iOS平台上只支持使用C-API来预测。
- `WITH_SWIG_PY`,必须设置为ON。在iOS平台上不支持通过swig调用来训练或者预测。
- `WITH_SWIG_PY`,必须设置为OFF。在iOS平台上不支持通过swig调用来训练或者预测。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correct the typo.

| `IOS_PLATFORM` | `IOS_ARCH` |
|----------------|------------|
| `OS` | armv7, armv7s, arm64 |
| `SIMULATOR` | i386, x86_64 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the html table to markdown table. Markdown table cannot be correctly shown on the website. It is shown as:

image

You can preview the generated documentation as #6014.

@@ -0,0 +1,132 @@
# Build PaddlePaddle for iOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add cross_compiling_for_ios_en.md to index_en.rst.

@wangkuiyi
Copy link
Collaborator Author

I don't know why I didn't merge this very old PR earlier. It seems that it has many conflicts with the recent version. So I am closing it.

@wangkuiyi wangkuiyi closed this Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants