Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOT][3.12] Compat for COMPARE_OP arg #61932

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Feb 21, 2024

PR types

Others

PR changes

Others

Description

对 Python3.12 中 COMPARE_OP oparg 进行适配,3.12 中会使用 instr.arg >> 4,低 4 bit 会用来作为 inline cache jump mask 使用(python/cpython#100924

PCard-66972

Copy link

paddle-bot bot commented Feb 21, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gouzil
Copy link
Member

gouzil commented Feb 21, 2024

可以看看gen_compare是否需要改变,或者下个pr也行

gouzil
gouzil previously approved these changes Feb 21, 2024
@SigureMo
Copy link
Member Author

可以看看gen_compare是否需要改变,或者下个pr也行

确实需要,之前都不知道这个 gen_compare

gouzil
gouzil previously approved these changes Feb 21, 2024
@SigureMo
Copy link
Member Author

@diadestiny 以后也可以来 review 下相关代码,如果从个人理解上觉得没啥问题就给个 approve 就好~当然有问题也可以以 review 的形式指出

(因为你没有这边的权限,所以只能通过 @ 的形式)

@SigureMo SigureMo merged commit f9593a5 into PaddlePaddle:develop Feb 22, 2024
30 checks passed
@SigureMo SigureMo deleted the sot/py312-compat-for-compare-op-arg branch February 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants