[SOT][3.12] Support POP_JUMP_IF_NONE and POP_JUMP_IF_NOT_NONE opcode in Python 3.12
#62120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
gouzil
previously approved these changes
Feb 27, 2024
|
需要解决一下冲突～ |
SigureMo
previously approved these changes
Feb 27, 2024
gouzil
reviewed
Feb 27, 2024
test/sot/skip_files_py312
Outdated
| @@ -1,9 +1,8 @@ | |||
| ./test_11_jumps.py | |||
| ./test_12_for_loop.py | |||
| ./test_21_global.py | |||
| ./test_break_graph.py | |||
| ./test_analysis_inputs.py | |||
SigureMo
previously approved these changes
Feb 27, 2024
gouzil
previously approved these changes
Feb 28, 2024
| @@ -1,9 +1,6 @@ | |||
| ./test_11_jumps.py | |||
There was a problem hiding this comment.
你的 PR 里是不是支持了 LOAD_FAST_CHECK 并解决了 POP_JUMP_FORWARD_IF_FALSE 生成问题？可以将这些拆到一个独立的 PR
There was a problem hiding this comment.
这个还没有，改回来了，昨晚没看清楚改错了
SigureMo
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
python 3.12 支持
POP_JUMP_IF_NONEandPOP_JUMP_IF_NOT_NONEtest_11_jumps.py单测里面还涉及到“opcode:
LOAD_FAST_CHECKis not supported.“等其他报错，暂不处理