[CINN]add matmul shape constrain #62567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
tc20042008
approved these changes
Mar 8, 2024
tc20042008
reviewed
Mar 8, 2024
| @@ -844,6 +844,25 @@ bool MatmulOpInferSymbolicShape( | |||
| shape_analysis->SetShapeOrDataForValue(op->result(0), | |||
| ShapeOrData{TensorExprs(out_dims)}); | |||
|
|
|||
| if ((ndims_x == ndims_y) && ndims_x >= 2) { | |||
| if (transpose_x_attr == false && transpose_y_attr == false) { | |||
| shape_analysis->CreateDimExprBuilder().CstrEq(x_dims[ndims_x - 1], | |||
There was a problem hiding this comment.
这个CreateDimExprBuilder函数很奇怪。
直接来讲应该是shape_analysis ->dim_expr_builder()-> CstrEq (...)，这里没有Create的感觉。
There was a problem hiding this comment.
ShapeAnalysis 目前还没提供 dim_expr_builder() 接口，仅能通过 CreateDimExprBuilder 构造出来
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-67164
增强matmul的逻辑推导限制