[Dynamic Shape]Fix SubstituteDimExprBasedOnConstraintsPass invalid bug #62570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
force-pushed
the
FixSubstitutePass
branch
from
c357d9d
to
b4d2c6c
Compare
tc20042008
previously approved these changes
Mar 8, 2024
… FixSubstitutePass
tc20042008
approved these changes
Mar 10, 2024
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
PaddlePaddle#62570) * [Dynamic Shape]Fix SubstituteDimExprBasedOnConstraintsPass invalid bug * simplify substituted dim_expr
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Mar 11, 2024
PaddlePaddle#62570) * [Dynamic Shape]Fix SubstituteDimExprBasedOnConstraintsPass invalid bug * simplify substituted dim_expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
pcard-76996
修复 SubstituteDimExprBasedOnConstraintsPass 未生效的 bug。现在 SubstituteDimExprBasedOnConstraintsPass 被移到了 ApplyGroupOpPass 函数内，因此 CanApplyOn 应该匹配 GroupOp 而非原来的 ModuleOp
Fix the bug that SubstituteDimExprBasedOnConstraintsPass does not take effect. SubstituteDimExprBasedOnConstraintsPass is now moved inside the ApplyGroupOpPass function, so CanApplyOn should match GroupOp instead of the original ModuleOp