Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR OpTest Fix No.26】 fix test_fused_token_prune_op #62644

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

Eddie-Wang1120
Copy link
Contributor

PR types

Others

PR changes

Others

Description

PIR Op单测修复
修复单测 fix test_fused_token_prune_op
修复后打开FLAGS_enable_pir_in_executor单测是否通过:是

Copy link

paddle-bot bot commented Mar 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 12, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 12, 2024
@luotao1
Copy link
Contributor

luotao1 commented Mar 13, 2024

需要解决下 PR-CI-Codestyle-Check 流水线的问题

@Eddie-Wang1120
Copy link
Contributor Author

Eddie-Wang1120 commented Mar 14, 2024

8818621cd731d005955a66bcf5ef26ce
想问一下在修复code-style后仍有CI没过去,我查看了一下其中的PR-CE-Framework,里面的算子都是因为No module named 'paddle'报错的,这个会是我的代码改动造成的吗 @luotao1 @kangguangli

f4775611b528c7be763a6c9762561780
以及PR-CI-Coverage中会出现Timeout错误,似乎是服务器没有响应?

@kangguangli
Copy link
Contributor

kangguangli commented Mar 14, 2024

Details

这些应该都不是你的问题,有时候CI机器/环境有问题,就会导致某些流水线挂掉,可以rerun下试试。我先帮你rerun了。

@Eddie-Wang1120
Copy link
Contributor Author

Details

这些应该都不是你的问题,有时候CI机器/环境有问题,就会导致某些流水线挂掉,可以rerun下试试。我先帮你rerun了。

好嘞,非常感谢

@Eddie-Wang1120
Copy link
Contributor Author

Details

这些应该都不是你的问题,有时候CI机器/环境有问题,就会导致某些流水线挂掉,可以rerun下试试。我先帮你rerun了。

CI已经全部通过了

Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有其他问题,非常棒!不过这里的变量名需要调整下,inds=indices,CLS我也不确定其含义。kernel中该变量叫做slimmed_indices。

paddle/fluid/pir/dialect/operator/ir/ops.yaml Outdated Show resolved Hide resolved
paddle/phi/api/yaml/op_compat.yaml Outdated Show resolved Hide resolved
Eddie-Wang1120 and others added 2 commits March 14, 2024 16:17
Co-authored-by: kangguangli <kangguangli@hotmail.com>
Co-authored-by: kangguangli <kangguangli@hotmail.com>
@Eddie-Wang1120
Copy link
Contributor Author

没有其他问题,非常棒!不过这里的变量名需要调整下,inds=indices,CLS我也不确定其含义。kernel中该变量叫做slimmed_indices。

谢谢!已经按照suggestion修改了

@Eddie-Wang1120
Copy link
Contributor Author

没有其他问题,非常棒!不过这里的变量名需要调整下,inds=indices,CLS我也不确定其含义。kernel中该变量叫做slimmed_indices。

PR-CE-Framework又出环境问题了o(╥﹏╥)o,麻烦rerun一下

bool keep_first_token,
bool keep_order,
MetaTensor* slimmed_x,
MetaTensor* clsi_nds) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MetaTensor* clsi_nds) {
MetaTensor* cls_inds) {

这里的没改过来,辛苦再修改下吧~

bool keep_first_token,
bool keep_order,
MetaTensor* slimmed_x,
MetaTensor* clsi_nds);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MetaTensor* clsi_nds);
MetaTensor* cls_inds);

@Eddie-Wang1120
Copy link
Contributor Author

将全部变量名更正并通过CI了

@kangguangli kangguangli requested a review from zyfncg March 18, 2024 07:19
@kangguangli kangguangli merged commit fd2389f into PaddlePaddle:develop Mar 18, 2024
30 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Mar 18, 2024

hi, @Eddie-Wang1120

  • 非常感谢你对飞桨的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

@Eddie-Wang1120 Eddie-Wang1120 deleted the eddie-dev branch March 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants