-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR OpTest Fix No.26】 fix test_fused_token_prune_op #62644
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
|
需要解决下 PR-CI-Codestyle-Check 流水线的问题 |
|
这些应该都不是你的问题,有时候CI机器/环境有问题,就会导致某些流水线挂掉,可以rerun下试试。我先帮你rerun了。 |
好嘞,非常感谢 |
CI已经全部通过了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有其他问题,非常棒!不过这里的变量名需要调整下,inds=indices,CLS我也不确定其含义。kernel中该变量叫做slimmed_indices。
Co-authored-by: kangguangli <kangguangli@hotmail.com>
Co-authored-by: kangguangli <kangguangli@hotmail.com>
谢谢!已经按照suggestion修改了 |
PR-CE-Framework又出环境问题了o(╥﹏╥)o,麻烦rerun一下 |
paddle/phi/infermeta/multiary.cc
Outdated
bool keep_first_token, | ||
bool keep_order, | ||
MetaTensor* slimmed_x, | ||
MetaTensor* clsi_nds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MetaTensor* clsi_nds) { | |
MetaTensor* cls_inds) { |
这里的没改过来,辛苦再修改下吧~
paddle/phi/infermeta/multiary.h
Outdated
bool keep_first_token, | ||
bool keep_order, | ||
MetaTensor* slimmed_x, | ||
MetaTensor* clsi_nds); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MetaTensor* clsi_nds); | |
MetaTensor* cls_inds); |
将全部变量名更正并通过CI了 |
hi, @Eddie-Wang1120
|
PR types
Others
PR changes
Others
Description
PIR Op单测修复
修复单测
fix test_fused_token_prune_op
修复后打开
FLAGS_enable_pir_in_executor
单测是否通过:是