Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvement for nn.TransformerEncoderLayer 易用性提升 #62788

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Mar 17, 2024

PR types

Others

PR changes

APIs

Description

对 paddle.nn.TransformerEncoderLayer 增加 layer_norm_eps 参数支持
Pytorch 中有 layer_norm_eps 参数: https://pytorch.org/docs/stable/_modules/torch/nn/modules/transformer.html#TransformerEncoderLayer

Copy link

paddle-bot bot commented Mar 17, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 17, 2024
@NKNaN NKNaN changed the title API improvement for nn.TransformerEncoderLayer API improvement for nn.TransformerEncoderLayer 易用性提升 Mar 17, 2024
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Contributor

@NKNaN decodelayer、encodelayer的API文档同时修改一下

@NKNaN
Copy link
Contributor Author

NKNaN commented Mar 19, 2024

@NKNaN decodelayer、encodelayer的API文档同时修改一下

好的

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Mar 19, 2024

@NKNaN decodelayer、encodelayer的API文档同时修改一下

好的

在修改API文档的同时,也把API映射文档进行修复一下吧:

https://github.com/PaddlePaddle/docs/tree/develop/docs/guides/model_convert/convert_from_pytorch/api_difference/nn/torch.nn.TransformerEncoderLayer.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants