Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dilation for conv_trans_op #6279

Merged

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Dec 5, 2017

fix #6189
fix #6423

@jacquesqiao
Copy link
Member

It seems no code is using attribute dilations?

@chengduoZH
Copy link
Contributor Author

The code is not fully implemented yet. @jacquesqiao

@chengduoZH chengduoZH force-pushed the feature/add_dilation_for_conv_trans branch from 1ea3e68 to d93bbf1 Compare December 8, 2017 11:35
@chengduoZH chengduoZH force-pushed the feature/add_dilation_for_conv_trans branch from e450dfb to 479ee27 Compare December 14, 2017 12:35
self.op_type = "conv2d_transpose_cudnn"


# #cudnn v5 does not support dilation conv.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接注释不太合适吧?对不同CUDNN_VERSION做测试,你可以参考这里:
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/gserver/tests/test_LayerGrad.cpp#L198

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得可以在下一个PR里面添加一个从python端获取CUDNN_VERSION的接口

Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit f605f16 into PaddlePaddle:develop Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants