Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine code（operator++） #6324

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Refine code（operator++） #6324

merged 1 commit into from
Dec 6, 2017

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Dec 6, 2017 •
edited
Loading

fix #6332

@chengduoZH chengduoZH requested a review from dzhwinter December 6, 2017 03:20
@chengduoZH chengduoZH force-pushed the profiling/refine_elementwise_add branch 3 times, most recently from a288c0a to eb367ae Compare December 6, 2017 03:37
@chengduoZH chengduoZH force-pushed the profiling/refine_elementwise_add branch from eb367ae to 8711a9a Compare December 6, 2017 04:48
dzhwinter
dzhwinter approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chengduoZH chengduoZH merged commit b30e8bc into PaddlePaddle:develop Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is better to avoid using the mod operator.
2 participants
@chengduoZH @dzhwinter