Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.335】Remove fluid operator sequence_conv #63288

Closed
wants to merge 8 commits into from

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 7, 2024

PR Category

Others

PR Types

Others

Description

Remove fluid operator sequence_conv

Copy link

paddle-bot bot commented Apr 7, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 7, 2024
@co63oc co63oc changed the title Remove fluid operator sequence_conv 【Hackathon 6th Fundable Projects No.3】Remove fluid operator sequence_conv Apr 8, 2024
@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects No.3】Remove fluid operator sequence_conv 【Hackathon 6th Fundable Projects 3 No.335】Remove fluid operator sequence_conv Apr 8, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luotao1 协调 预测同学确认一下,删除的pass和算子预测是否仍在使用。
@luotao1 协调 红雨看看如下三个单测。我担心这个算子在某些业务上仍有使用:
test/book/notest_understand_sentiment.py
test/book/test_recommender_system.py
test/legacy_test/test_dist_text_classification.py

Comment on lines -237 to -238
"attention_lstm_fuse_pass", //
"seqconv_eltadd_relu_fuse_pass", //
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里删除seqconv_eltadd_relu_fuse_pass,需要预测同学确认。

Comment on lines -1 to -4
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也需要预测同学帮忙看看,预测是否还是用这个算子。

@luotao1
Copy link
Contributor

luotao1 commented Apr 16, 2024

sequence_conv @danleifeng 表示不能删,算子在PS场景用的挺多的。先关闭

@luotao1 luotao1 closed this Apr 16, 2024
@co63oc co63oc deleted the fix_seq_conv branch May 29, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants