Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libprotobuf-lite.a when install. #6340

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Add libprotobuf-lite.a when install. #6340

merged 3 commits into from
Dec 21, 2017
+2 −2

Conversation

hedaoyuan
Copy link
Contributor

No description provided.

@hedaoyuan hedaoyuan requested a review from Xreki December 6, 2017 08:30
@Xreki
Copy link
Contributor

Xreki commented Dec 7, 2017

I am not sure, do we need to keep libprotobuf.a?

@hedaoyuan
Copy link
Contributor Author

hedaoyuan commented Dec 8, 2017 •
edited
Loading

I think paddle mobile inference library only need release libprotobuf-lite.a.

@Xreki
Copy link
Contributor

Xreki commented Dec 21, 2017

我本来想，或许Paddle应该直接链接libprotobuf-lite.a，但我发现还需要涉及到一些别的地方的修改。所以先merge这个PR，我后面再提PR把Paddle中对protobuf的链接都改过来吧。

@Xreki Xreki merged commit 0295b00 into PaddlePaddle:develop Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedaoyuan @Xreki