Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 6th Fundable Projects 2 No.35】 modernize-use-emplace_1-part #63847

Merged
merged 3 commits into from
Apr 30, 2024
Merged

【Hackathon 6th Fundable Projects 2 No.35】 modernize-use-emplace_1-part #63847

merged 3 commits into from
Apr 30, 2024

Conversation

ApricityXX
Copy link
Contributor

@ApricityXX ApricityXX commented Apr 24, 2024 •
edited
Loading

PR Category

Others

PR Types

Bug fixes

Description

引入 clang-tidy Tracking Issue #64128
fix modernize-use-emplace（16/16）

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 24, 2024
@ApricityXX ApricityXX changed the title 【Hackathon 6th Fundable Projects No.23】 modernize-use-emplace 【Hackathon 6th Fundable Projects 2 No.23】 modernize-use-emplace Apr 26, 2024
ForFishes
ForFishes approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzhang533 jzhang533 merged commit 8a19b43 into PaddlePaddle:develop Apr 30, 2024
30 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 6, 2024
@ApricityXX @co63oc
【Hackathon 6th Fundable Projects 2 No.23】 modernize-use-emplace (Padd…
89d5d3f 
…lePaddle#63847)

* 4.24

* 4.24_2
@ApricityXX ApricityXX mentioned this pull request May 8, 2024
Open
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 10, 2024
@ApricityXX @co63oc
【Hackathon 6th Fundable Projects 2 No.23】 modernize-use-emplace (Padd…
5ad0b3b 
…lePaddle#63847)

* 4.24

* 4.24_2
@ApricityXX ApricityXX changed the title 【Hackathon 6th Fundable Projects 2 No.23】 modernize-use-emplace 【Hackathon 6th Fundable Projects 2 No.35】 modernize-use-emplace_1-part May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForFishes ForFishes ForFishes approved these changes

@zhiqiu zhiqiu Awaiting requested review from zhiqiu zhiqiu is a code owner

Assignees

@luotao1 luotao1

@Galaxy1458 Galaxy1458

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ApricityXX @CLAassistant @ForFishes @jzhang533 @luotao1 @Galaxy1458