use cumprod fix bug of prod_grad #64127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YibinLiu666
requested review from
cxxly,
xiaoguoguo626807,
Charles-hit,
cyber-pioneer,
JiabinYang,
wanghuancoder,
luotao1,
Aurelius84,
XiaoguangHu01 and
qili93
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
29 tasks
…prod_fix pull cumprod
| self.check_grad( | ||
| ['X'], | ||
| 'Out', | ||
| check_pir=True, |
There was a problem hiding this comment.
Suggested change
| check_pir=True, | |
| check_pir=True, | |
| check_prim_pir=True, |
| self.check_grad( | ||
| ['X'], | ||
| 'Out', | ||
| check_pir=True, |
There was a problem hiding this comment.
Suggested change
| check_pir=True, | |
| check_pir=True, | |
| check_prim_pir=True, |
| ) | ||
| return x_cotangent[0] | ||
|
|
||
| x = np.random.random((5, 6, 10)).astype(self.data_type) |
| @@ -88,6 +96,7 @@ void CumprodKernel(const Context& dev_ctx, | |||
| } | |||
| } | |||
| } | |||
| memcpy(out_ptr, out_data, out->numel() * sizeof(T)); | |||
There was a problem hiding this comment.
建议加上判断：if (x_data == out_ptr)
cyber-pioneer
previously approved these changes
May 30, 2024
cyber-pioneer
approved these changes
May 31, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 3, 2024
* add reverse and exclusive * support reverse and exclusive * fix inplace test * fix make on xpu * remove print * update test time * fix prod_grad use cumprod * add 1-5D test * speed up test * mul out_grad * update test * Update CMakeLists.txt * update op_version * update detail.h * update composite * update detail.h * stage * update test * only test on gpu * update details.h * CI * Update composite_backward_api.h * Update details.h * update test * update * Update test_reduce_op.py * fix cumprod cpu bug * update test * update test * update * update * ci * ci * remove comment * CI * Your commit message * CI * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Bug fixes
Description
使用双向cumprod修复prod_grad在x有0的时候出现nan的bug
测试代码：
修复前：
修复后：
Important
单测会挂在老动态图+CPU配置上，所以禁用了单测的CPU测试