【Fix PIR Unittest No.66】refine pir unique_name and set_parameter #64312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
wanghuancoder
changed the title
Closed
Aurelius84
previously approved these changes
May 16, 2024
| PADDLE_ENFORCE_EQ(param->type(), | ||
| parameter.type(), | ||
| phi::errors::InvalidArgument( | ||
| "Duplicate parameter %s with diffrient type.", name)); |
There was a problem hiding this comment.
Suggested change
| "Duplicate parameter %s with diffrient type.", name)); | |
| "Duplicate parameter %s with different type.", name)); |
Aurelius84
previously approved these changes
May 16, 2024
Aurelius84
approved these changes
May 17, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 18, 2024
…dlePaddle#64312) * refine pir unique_name and set_parameter
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 19, 2024
…dlePaddle#64312) * refine pir unique_name and set_parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
Pcard-67164
修复PIR不支持test_imperative_gan.py的问题：
test_imperative_gan利用了静态图，两个main_program共用一个start_program和scope的特性，暴露了PIR的两个问题：
本PR给予修复。
关联Issue：#63740