Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prim]Add pd_op.add Operation in ALLOW_DYNAMIC_SHAPE_VJP_OPS #64342

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

WintersMontagne10335
Copy link
Contributor

@WintersMontagne10335 WintersMontagne10335 commented May 15, 2024

PR Category

CINN

PR Types

Bug fixes

Description

PaddleTest 中 layercase/sublayer1000/Seg_cases/danet_danet_resnet50_os8_voc12aug_512x512_40k/SIR_34.py 报错,详细信息如下:

    NotImplementedError: (Unimplemented) pd_op.add_grad DOES NOT have InferSymbolicShapeInterface! (at /home/aistudio/Paddle/paddle/pir/src/dialect/shape/transforms/shape_optimization_pass.cc:333)

将 "pd_op.add" 添加至 ALLOW_DYNAMIC_SHAPE_VJP_OPS,解决了这个问题。
之后又报错,ReduceSum 符号推导失败。应当是符号推导中向 InferSymbolicShapeContext 迁移时,有部分逻辑没有迁移过去,小小地推进了一下。
后续接着报错,

    NotImplementedError: (Unimplemented) pd_op.conv2d_grad DOES NOT have InferSymbolicShapeInterface! (at /home/aistudio/Paddle/paddle/pir/src/dialect/shape/transforms/shape_optimization_pass.cc:333)

因为 conv2d 反向算子拆分暂未实现,只能先推进到这里了。

Copy link

paddle-bot bot commented May 15, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 15, 2024
@WintersMontagne10335 WintersMontagne10335 changed the title Winters027 Fixed some bugs for CINN May 16, 2024
@Aurelius84 Aurelius84 changed the title Fixed some bugs for CINN [Prim]Add pd_op.add Operation in ALLOW_DYNAMIC_SHAPE_VJP_OPS May 17, 2024
Copy link

paddle-ci-bot bot commented May 29, 2024

Sorry to inform you that c2de38f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link

paddle-ci-bot bot commented Jul 1, 2024

Sorry to inform you that db84cdf's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants