Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo WITH_TEST to WITH_TESTING #6473

Merged
merged 2 commits into from
Dec 13, 2017
Merged

typo WITH_TEST to WITH_TESTING #6473

merged 2 commits into from
Dec 13, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Dec 11, 2017

fix #6472

@luotao1 luotao1 requested a review from typhoonzero December 11, 2017 10:32
typhoonzero
typhoonzero reviewed Dec 11, 2017
View reviewed changes
doc/howto/dev/contribute_to_paddle_cn.md Outdated
@@ -87,7 +87,7 @@ no changes added to commit (use "git add" and/or "git commit -a")
随后可以用这个开发镜像开始build PaddlePaddle的源码。比如如果要build一个不依赖GPU，但是支持AVX指令集，并且包括unit tests的PaddlePaddle，可以：

```bash
➜ docker run -v $(pwd):/paddle -e "WITH_GPU=OFF" -e "WITH_AVX=ON" -e "WITH_TEST=ON" paddle:dev
➜ docker run -v $(pwd):/paddle -e "WITH_GPU=OFF" -e "WITH_AVX=ON" -e "WITH_TESTING=ON" paddle:dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle:dev => paddle:latest-dev ?或者paddle:[version tag]-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

typhoonzero
typhoonzero approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 79f0ab5 into PaddlePaddle:develop Dec 13, 2017
@luotao1 luotao1 deleted the with_test branch December 13, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

文档中使用WITH_TEST的地方，应该为WITH_TESTING
2 participants
@luotao1 @typhoonzero