【Hackathon 6th Fundable Projects 4 No.5】remove parallel executor in run_program op -part #64818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ccsuzzh
requested review from
zhwesky2010,
wanghuancoder and
Aurelius84
as code owners
ccsuzzh
changed the title
13 tasks
wanghuancoder
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
LGTM 请 @luotao1 尽早合入，剩余的comment可以由海师傅后面逐步清理。这个PR比较大。一方面防止冲突，另一方面尽早合入看看各方的反馈。
| @@ -63,7 +69,7 @@ constexpr char kUseHierarchicalAllReduce[] = "use_hierarchical_allreduce"; | |||
| typedef std::unordered_set<VarHandleBase *> GraphDepVars; | |||
| constexpr char kGraphDepVars[] = "dep_vars"; | |||
|
|
|||
| typedef std::unordered_map<std::string, details::VariableInfo> FusedVars; | |||
| typedef std::unordered_map<std::string, VariableInfo> FusedVars; | |||
| constexpr char kFusedVars[] = "fused_vars"; | |||
| constexpr char kFusedVarNamePrefix[] = "@FUSEDVAR@"; | |||
There was a problem hiding this comment.
这些剩余的代码是有人还在使用？可以梳理一下，如果必须使用，可以换个位置。或者通过这个线索可以发现一些更多可以删除的代码。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Others
Description
No.5 移除
ParallelExecutor执行器相关代码TODO:
整理与PE相关的代码，尽可能将无用代码清理干净
继续调研run_program op是否能够直接删除，可以结合Fundable Projects 3一同处理
【Hackathon 6th Fundable Projects No.4】Paddle 框架旧执行器功能退场 Tracking Issue #63510