Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typing][A-39,A-47,A-51] Add type annotations for
paddle/optimizer/optimizer.py
#65076[Typing][A-39,A-47,A-51] Add type annotations for
paddle/optimizer/optimizer.py
#65076Changes from 17 commits
bf4b1ec
3712142
bde8a8d
3977d61
dbd7fdc
5b40e80
22658fd
3c4b045
e6bba9f
4bff18e
e492299
0333fa6
2612591
d5bf9ef
c9c17e3
c8ab7ee
050e10b
160e808
011966d
9789477
2e7ecee
2c790ac
e728415
851f46f
1c294ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不用放这下面
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非暴露,加个下划线吧,可以不用放到
TYPE_CHECKING
下面There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我把 ParameterConfig 定义在 optimizer.py 的
TYPE_CHECKING
下面(里面用到很多type_checking里导入的类),这里不放在TYPE_CHECKING
下面是不是会找不到 ParameterConfig 啊There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 肯定是要改一起改啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个装饰器没加类型提示吧,应该会丢失掉类型信息,可以参考 #64954 加一下
这个实现和其他的不太一样,需要自己看一下