Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typing][A-30,A-31] Add type annotations for paddle/nn/initializer/dirac.py #65087

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[Typing][A-30,A-31] Add type annotations for paddle/nn/initializer/dirac.py #65087

merged 3 commits into from
Jun 13, 2024

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 12, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Improvements

Description

类型标注：

  • paddle/nn/initializer/dirac.py
  • paddle/nn/initializer/initializer.py

Related links

@SigureMo @megemini

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 12, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 12, 2024
@megemini megemini mentioned this pull request Jun 12, 2024
Closed
SigureMo
SigureMo reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议先完成基类（Initializer）的标注，不然大概率检查的不够完全

@gouzil gouzil changed the title [Typing][A-30] Add typing annotations for paddle/nn/initializer/dirac.py [Typing][A-30,A-31] Add typing annotations for paddle/nn/initializer/dirac.py Jun 12, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 13, 2024
SigureMo
SigureMo approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit f2746e1 into PaddlePaddle:develop Jun 13, 2024
31 of 33 checks passed
@SigureMo SigureMo changed the title [Typing][A-30,A-31] Add typing annotations for paddle/nn/initializer/dirac.py [Typing][A-30,A-31] Add type annotations for paddle/nn/initializer/dirac.py Jun 16, 2024
@gouzil gouzil deleted the typehint/fix_initializer_dirac branch July 20, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gouzil @SigureMo @luotao1