[Typing][A-44] Add type annotations for paddle/optimizer/lbfgs.py
#65308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jun 22, 2024
There was a problem hiding this comment.
还有几个 api 别漏了哈 ～ state_dict step minimize ～～～
咱们这次主要是关注 公开 api ，重点关注不以 _ 开头的那些函数或者方法 ～
另外，ISSUE 里面统计的每个文件中 api 数量可能不准，比如，有的是一个类，只统计了 1 次，但是类里面的方法其实都需要修改 ～ 可以参考官网有哪些接口，宁缺勿漏 宁多勿漏 吧 ～ 🤟🤟🤟
…into typing-a44-lbfgs
SigureMo
requested changes
Jun 24, 2024
python/paddle/optimizer/lbfgs.py
Outdated
| @@ -452,7 +462,7 @@ def __init__( | |||
|
|
|||
| self._numel_cache = None | |||
|
|
|||
| def state_dict(self): | |||
| def state_dict(self) -> dict[str, Any]: | |||
python/paddle/optimizer/lbfgs.py
Outdated
| @@ -553,7 +563,7 @@ def _directional_evaluate(self, closure, x, alpha, d): | |||
| return loss, flat_grad | |||
|
|
|||
| @framework.non_static_only | |||
| def step(self, closure): | |||
| def step(self, closure) -> Any: | |||
python/paddle/optimizer/lbfgs.py
Outdated
| @@ -778,7 +788,7 @@ def obj_func(x, alpha, d): | |||
|
|
|||
| def minimize( | |||
| self, loss, startup_program=None, parameters=None, no_grad_set=None | |||
| ): | |||
| ) -> Any: | |||
SigureMo
reviewed
Jun 24, 2024
python/paddle/optimizer/lbfgs.py
Outdated
Comment on lines
38
to
45
| class _LbfgsStateDict(TypedDict): | ||
| learning_rate: float | ||
| max_iter: int | ||
| max_eval: NotRequired[int] | ||
| tolerance_grad: float | ||
| tolerance_change: float | ||
| history_size: int | ||
| line_search_fn: NotRequired[str] |
SigureMo
requested changes
Jun 24, 2024
python/paddle/optimizer/lbfgs.py
Outdated
Comment on lines
38
to
48
| func_evals: int | ||
| n_iter: int | ||
| d: Tensor | ||
| alpha: int | ||
| old_yk: list[Tensor] | ||
| old_sk: list[Tensor] | ||
| ro: Tensor | ||
| H_diag: Tensor | ||
| prev_flat_grad: Tensor | ||
| prev_loss: float | ||
| al: Tensor |
There was a problem hiding this comment.
他这个是返回state的值吧？state里面打印出来这些参数
SigureMo
reviewed
Jun 24, 2024
python/paddle/optimizer/lbfgs.py
Outdated
| __all__ = [] | ||
|
|
||
|
|
||
| class _LbfgsStateDict(TypedDict): | ||
| state: str | ||
| packed_state: _LbfgsStateDict |
There was a problem hiding this comment.
啊哈哈，我没看明白，他代码返回的是dict,然后dict里面给了键 state, 和state对应的dict的键的值
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
…addlePaddle#65308) --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
A44