Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typing][A-24] Add type annotations for paddle/nn/layer/transformer.py #65457

Merged
merged 5 commits into from
Jun 27, 2024
Merged

[Typing][A-24] Add type annotations for paddle/nn/layer/transformer.py #65457

merged 5 commits into from
Jun 27, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

Add type annotations for paddle/nn/layer/transformer.py

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jun 25, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 25, 2024
@SigureMo SigureMo mentioned this pull request Jun 25, 2024
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2024
megemini
megemini reviewed Jun 26, 2024
View reviewed changes
python/paddle/nn/layer/transformer.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/transformer.py Outdated Show resolved Hide resolved
@SigureMo SigureMo changed the title [Typing][A-24] Add type annotations for paddle/nn/layer/transformer.py [Typing][A-24] Add type annotations for paddle/nn/layer/transformer.py Jun 27, 2024
SigureMo
SigureMo reviewed Jun 27, 2024
View reviewed changes
python/paddle/nn/layer/transformer.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/transformer.py Outdated Show resolved Hide resolved
SigureMo
SigureMo approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit e5e629a into PaddlePaddle:develop Jun 27, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megemini megemini megemini left review comments

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Asthestarsfalll @megemini @SigureMo @luotao1