[Typing][A-83] Add type annotations for paddle/vision/transforms/functional.py
#65560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jun 29, 2024
Comment on lines
1024
to
1032
| def erase( | ||
| img: _ImageDataLayout, | ||
| i: int, | ||
| j: int, | ||
| h: int, | ||
| w: int, | ||
| v: int, | ||
| inplace: bool = False, | ||
| ) -> _ImageDataLayout: |
There was a problem hiding this comment.
这里的 img 和输出不对吧？貌似应该是 img (paddle.Tensor | np.array | PIL.Image) ～ 可以考虑用 TypeVar ~
There was a problem hiding this comment.
这里补全没注意选错了，其他的应该没问题吧
_ImageDataType: TypeAlias = Union[Tensor, PILImage, npt.NDArray[Any]]There was a problem hiding this comment.
这里（包括其他几个函数）为啥不用 TypeVar？ TypeAlias 不能保证输入输出的类型一致吧 ～
megemini
reviewed
Jun 29, 2024
SigureMo
previously approved these changes
Jun 29, 2024
gouzil
approved these changes
Jun 29, 2024
SigureMo
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
Add type annotations for
paddle/vision/transforms/functional.py