[Typing][B-33,B-37] Add type annotations for python/paddle/amp/{amp_lists,__init__}.py
#65633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 2, 2024
python/paddle/amp/amp_lists.py
Outdated
| @@ -118,7 +121,7 @@ def white_list(): | |||
| return white_list | |||
|
|
|||
|
|
|||
| def black_list(): | |||
| def black_list() -> dict[str, dict[str, Any]]: | |||
There was a problem hiding this comment.
Suggested change
| def black_list() -> dict[str, dict[str, Any]]: | |
| def black_list() -> dict[str, dict[str, set[str]]]: |
应该也还是 set[str] 的样子 ～
另外，@SigureMo 这里有必要用 TypedDict 吗?
There was a problem hiding this comment.
不用了吧，这又不是公开 API，这里的输入输出的「协议」让开发的人自己把握就好了，改成 TypedDict 他们反而维护不起来了
SigureMo
reviewed
Jul 2, 2024
| @@ -14,6 +14,9 @@ | |||
|
|
|||
| # The set of ops that support fp16 and bf16 calculation and are considered numerically- | |||
| # safe and performance-critical. These ops are always converted to fp16 or bf16. | |||
|
|
|||
There was a problem hiding this comment.
这俩都不是公开 API，这个文件的统计是统计错了还是漏标记公开 API 了？
There was a problem hiding this comment.
这俩是我这边手动添加的 ～
我这里统计的依据基本是遵循 __all__ 的范围，有一些虽然没在里面，但是在 __init__.py 里面导进去了，我看挺简单的也就放进去了 ～
SigureMo
changed the title
python/paddle/amp/amp_lists.py、python/paddle/amp/__init__.pypython/paddle/amp/amp_lists.py、python/paddle/amp/__init__.py
SigureMo
changed the title
python/paddle/amp/amp_lists.py、python/paddle/amp/__init__.pypython/paddle/amp/{amp_lists,__init__}.py
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
…lists,__init__}.py` (PaddlePaddle#65633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
B-33
B-37