[Typing][B-02,B-04] Add type annotations for python/paddle/distribution/{bernoulli, binomial}.py
#65727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion/{bernoulli, binomial}.py`
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jul 4, 2024
| @@ -67,7 +74,13 @@ class Binomial(distribution.Distribution): | |||
| [2.94053698, 3.00781751, 2.51124287]) | |||
| """ | |||
|
|
|||
| def __init__(self, total_count, probs): | |||
| dtype: DTypeLike | |||
There was a problem hiding this comment.
这个应该是通过 get_default_dtype 得到的，应该是某一个类型而不是 Union
根据实现，应该是 _DTypeLiteral
可以顺手标注下 set_default_dtype 和 get_default_dtype 两个 API～（新增了 B-43）
|
|
||
| def __init__( | ||
| self, total_count: int | Tensor, probs: float | Tensor | ||
| ) -> None: | ||
| self.dtype = paddle.get_default_dtype() | ||
| self.total_count, self.probs = self._to_tensor(total_count, probs) |
There was a problem hiding this comment.
下面的 _to_tensor 可以顺手标一下，文档里都给出类型了
另外我目测了下，返回值应该是 list[Tensor]？虽然确实是两个元素就是了，文档里写的可能并不准确
SigureMo
reviewed
Jul 4, 2024
| def __init__(self, probs, name=None): | ||
| name: str | ||
| probs: Tensor | ||
| logits: Tensor |
|
Sorry to inform you that 0739a08's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
…ion/{bernoulli, binomial}.py` (PaddlePaddle#65727)
---------
Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
Add type annotations for
python/paddle/distribution/{bernoulli, binomial}.py: