【Fix PIR Unittest No.276,342,395,377,435,445】Fix gather_nd/tree/histogramdd UT #65799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
changed the title
Aurelius84
changed the title
Aurelius84
changed the title
Closed
wanghuancoder
approved these changes
Jul 11, 2024
| @@ -221,6 +225,7 @@ def gather_tree(ids: Tensor, parents: Tensor) -> Tensor: | |||
| raise ValueError("The ids's shape must be the same as parents' shape. ") | |||
|
|
|||
| if in_dynamic_or_pir_mode(): | |||
| check_dtype(parents.dtype, "parents", ['int32', 'int64'], 'gather_tree') | |||
There was a problem hiding this comment.
这个最好加一个if in_pir_mode()更好的写法是：
if in_dynamic_mode():
_c_ops.xxx
if in_pir_mode():
check
_c_ops.xxx
这样不会影响动态图性能
There was a problem hiding this comment.
check_xx系列的函数实现里已经内含了跳过动态图处理的判断，相对轻量级
| @@ -5277,6 +5277,7 @@ def gather_nd(x: Tensor, index: Tensor, name: str | None = None) -> Tensor: | |||
|
|
|||
| """ | |||
| if in_dynamic_or_pir_mode(): | |||
| check_dtype(index.dtype, "index", ['int32', 'int64'], 'gather_nd') | |||
There was a problem hiding this comment.
check_xx系列的函数实现里已经内含了跳过动态图处理的判断，相对轻量级
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Not User Facing
Description
Pcard-67164
关联Issue：#63740