[Typing][B-59] Add type annotations for python/paddle/text/viterbi_decode.py
#65919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Jul 11, 2024
python/paddle/text/viterbi_decode.py
Outdated
Comment on lines
157
to
158
| potentials: Tensor | ||
| lengths: Tensor |
There was a problem hiding this comment.
在forward里面用的，这里不用初始化吗？
There was a problem hiding this comment.
这里从来就不是「初始化」，这里是表明该类的实例在初始化后会有哪些属性，以及相应的类型，初始化怎么可能不绑定值？而且初始化是对运行时有影响的，我们怎么可能允许在这个任务加「初始化」？
There was a problem hiding this comment.
看了m佬提供的#65660 (comment) ，明白了。
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
B59