Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Fix PIR Unittest BUAA No.411】Fix test_one_hot_v2_op PIR mode #66204

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Luohongzhige
Copy link
Contributor

@Luohongzhige Luohongzhige commented Jul 18, 2024

PR Category

Others

PR Types

Others

Description

Fix some bugs in test_one_hot_v2_op.py
PIR中弃用.desc

Copy link

paddle-bot bot commented Jul 18, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2024

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 18, 2024
@Luohongzhige Luohongzhige changed the title My cool stuff Fix PIR Unittest No.37 Jul 18, 2024
@Luohongzhige Luohongzhige changed the title Fix PIR Unittest No.37 【Fix PIR Unittest BUAA No.411】Fix test_one_hot_v2_op PIR mode Jul 19, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 19, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉不必要的文件可approve

Comment on lines 1 to 24
# Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import unittest

import numpy as np
from op_test import OpTest

import paddle
from paddle import base
from paddle.base import core
from paddle.pir_utils import test_with_pir_api

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个删掉!

Copy link
Contributor Author

@Luohongzhige Luohongzhige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复完,从deprecated目录移出

wanghuancoder
wanghuancoder previously approved these changes Jul 29, 2024
@luotao1
Copy link
Contributor

luotao1 commented Jul 29, 2024

@Luohongzhige 有冲突了

@Luohongzhige
Copy link
Contributor Author

@Luohongzhige 有冲突了

已解决

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 现在是只需要移动,不需要做修改了么

@Luohongzhige
Copy link
Contributor Author

image 现在是只需要移动,不需要做修改了么

是的,冲突就是这个修改,在我跑CI的时候不知道谁也改了这个还merge了。。。

@wanghuancoder wanghuancoder merged commit 03cdf2c into PaddlePaddle:develop Jul 31, 2024
31 checks passed
Lans1ot pushed a commit to Lans1ot/Paddle that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants