【Fix PIR Unittest No.463 BUAA】Fix some test case in PIR #66208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
Caogration
changed the title
SigureMo
reviewed
Jul 19, 2024
| @@ -29,11 +29,12 @@ class TestVarInfo(unittest.TestCase): | |||
| def test_var_info(self): | |||
There was a problem hiding this comment.
此单测明显是在测试 Variable._set_info 和 Variable._get_info，修改后的测试用例已经违背了原单测 case 的用意
从接口层面来看，_set_info 和 _get_info 只是老 IR Variable 上的私有接口，且整个框架内都没有使用，因此应当视为弃用的接口，该单测没有必要适配，直接移动到 test/deprecated/legacy_test/test_var_info_deprecated.py 即可
另外麻烦将相关修改从 #66281 中剔除，属于无关修改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
OthersPR Types
OthersDescription
PIR下的tensor不支持_set_info和_get_info等方法赋予属性，若要赋予属性，可以重新分配和维护一个字典用于储存其属性关联issue: #63740