-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Fix PIR Unittest No.398,No.399】 #66299
【Fix PIR Unittest No.398,No.399】 #66299
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
input_pd.grad = paddle.to_tensor( | ||
np.random.random([1, 2]).astype(np.float32) | ||
) | ||
clip_grad_norm_(input_pd, max_norm=2, norm_type=float("inf")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该去看clip_grad_norm_里有什么问题,为什么在PIR下不支持。而不是用OldIrGuard裹上了之。
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个单测报了问题,就应该修问题,而不是放到_deprecated.py下
Sorry to inform you that 7dbbd0f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
PR Category
Others
PR Types
Bug fixes
Description
No.398
AttributeError: 'paddle.base.libpaddle.pir.Value' object has no attribute 'grad'
使用with paddle.pir_utils.OldIrGuard() 包裹问题代码块
No.399
使用paddle.static.nn的api,在代码前加入paddle.enable_static(),同时给文件加上_deprecated后缀
关联issue: #63740