Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Fix PIR Unittest No.462 BUAA】Fix some test case in PIR #66312

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

BHmingyang
Copy link
Contributor

PR Category

Others

PR Types

Others

Description

def test_start_dtype():
start = paddle.static.data(
shape=[1], dtype="float64", name="start"
)
paddle.linspace(start, 10, 1, dtype="float32")
# test_start_dtype()
self.assertRaises(ValueError, test_start_dtype)
在新版静态图测试下没有raise ValueError
调试方法:
首先注释掉self.assertRaises(ValueError, test_start_dtype)
添加test_start_dtype(),让旧版静态图测试挂掉
找到对应旧版静态图测试实现的功能,添加到新版静态图测试下

Copy link

paddle-bot bot commented Jul 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 22, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 22, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -223,6 +227,7 @@ def test_start_dtype():
)
paddle.linspace(start, 10, 1, dtype="float32")

# test_start_dtype()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行代码不该有,在下次提别的PR时,顺手把这行代码删掉。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@luotao1 luotao1 merged commit 0f0ab20 into PaddlePaddle:develop Jul 24, 2024
31 checks passed
inaomIIsfarell pushed a commit to inaomIIsfarell/Paddle that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants