Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Infer Symbolic Shape BUAA No.38】Add FakeChannelWiseQuantizeAbsMax operator support for CINN compiler #66612

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

Jeff114514
Copy link
Contributor

@Jeff114514 Jeff114514 commented Jul 26, 2024

PR Category

CINN

PR Types

Others

Description

添加FakeChannelWiseQuantizeAbsMax算子的符号推导接口

Copy link

paddle-bot bot commented Jul 26, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 26, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 26, 2024
@gongshaotian gongshaotian self-requested a review July 29, 2024 06:39
Copy link
Contributor

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR type 修改为 other,标题名称和PR描述太简陋

@@ -339,6 +339,42 @@ bool DistributeFpnProposalsOpInferSymbolicShape(
return true;
}

bool FakeChannelWiseQuantizeAbsMaxOpInferSymbolicShape(
Copy link
Contributor

@gongshaotian gongshaotian Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看一下添加OpTest单测是否复杂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经存在TestFakeChannelWiseQuantizeAbsMaxOp(OpTest)但没有打开 check_pir 和 check_symbol_infer 两个flag,请问这个情况如何修改

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 不需要再修改单测了 2. 需要把PR标题修改为全英文

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已完成修改

@Jeff114514 Jeff114514 changed the title 【Infer Symbolic Shape BUAA No.38】FakeChannelWiseQuantizeAbsMax 【Infer Symbolic Shape BUAA No.38】为CINN编译器增加FakeChannelWiseQuantizeAbsMax算子推导 Jul 29, 2024
@Jeff114514 Jeff114514 changed the title 【Infer Symbolic Shape BUAA No.38】为CINN编译器增加FakeChannelWiseQuantizeAbsMax算子推导 【Infer Symbolic Shape BUAA No.38】Add FakeChannelWiseQuantizeAbsMax operator support for CINN compiler Jul 29, 2024
Copy link
Contributor

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit b16a774 into PaddlePaddle:develop Aug 1, 2024
31 checks passed
Lans1ot pushed a commit to Lans1ot/Paddle that referenced this pull request Aug 5, 2024
…erator support for CINN compiler (PaddlePaddle#66612)

* summon

* add test

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants