Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-74] Add type annotations for python/paddle/incubate/nn/functional/fused_matmul_bias.py #66656

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

Betelgeu
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/incubate/nn/functional/fused_matmul_bias.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jul 27, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 27, 2024
bias: Tensor,
trans_x: bool = False,
trans_y: bool = False,
activation: str | None = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activation (str, optional): Activation function, Currently, the available activation functions are limited to "gelu" (Gaussian Error Linear Unit) and "relu" (Rectified Linear Unit). These activation functions are applied to the output of the bias add. Default: None.

可以用 Literal 限制一下 activation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提醒,已经提交commit修改

@SigureMo SigureMo changed the title [Typing][C-74] Add type annotations for python/paddle/incubate/nn/functional/fused_matmul_bias.py [Typing][C-74] Add type annotations for python/paddle/incubate/nn/functional/fused_matmul_bias.py Jul 28, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 03e5e1a into PaddlePaddle:develop Jul 28, 2024
31 checks passed
inaomIIsfarell pushed a commit to inaomIIsfarell/Paddle that referenced this pull request Jul 31, 2024
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants