Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-19] Add type annotations for python/paddle/distributed/communication/recv.py #66694

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

Lans1ot
Copy link
Contributor

@Lans1ot Lans1ot commented Jul 29, 2024

PR Category

User Experience

PR Types

Improvements

Description

尝试为函数增加类型
被@contextlib.contextmanager包裹的不知道怎么写返回类型,查看代码发现有关的c代码都是void,所以就先返回None了。
这是之前的PR,不好改就重新开了一个PR

Copy link

paddle-bot bot commented Jul 29, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 29, 2024
@Lans1ot Lans1ot closed this Jul 29, 2024
@Lans1ot Lans1ot reopened this Jul 29, 2024
@Lans1ot Lans1ot closed this Jul 29, 2024
@Lans1ot Lans1ot reopened this Jul 29, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 29, 2024
@SigureMo SigureMo changed the title [Typing][C-15,C-16,C-19] Add type annotations for paddle/tensor/* [Typing][C-19] Add type annotations for paddle/tensor/* Jul 30, 2024
@SigureMo SigureMo changed the title [Typing][C-19] Add type annotations for paddle/tensor/* [Typing][C-19] Add type annotations for python/paddle/distributed/communication/recv.py Jul 30, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 220ffec into PaddlePaddle:develop Jul 31, 2024
31 checks passed
inaomIIsfarell pushed a commit to inaomIIsfarell/Paddle that referenced this pull request Jul 31, 2024
Lans1ot added a commit to Lans1ot/Paddle that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants