Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-4][C-7][C-9][C-18]Add type annotations for python/paddle/distributed/auto_parallel/interface.py+strategy.py+placement_type.py and python/paddle/distributed/communication/group.py #66710

Closed
wants to merge 6 commits into from

Conversation

lwkhahaha
Copy link
Contributor

@lwkhahaha lwkhahaha commented Jul 29, 2024

PR Category

Others

PR Types

Others

Description

Add type annotations for python/paddle/distributed/auto_parallel/ interface.py

Copy link

paddle-bot bot commented Jul 29, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 29, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 29, 2024
…distributed/auto_parallel/interface.py+strategy.py+placement_type.py and python/paddle/distributed/communication/group.py
@lwkhahaha lwkhahaha reopened this Jul 30, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是 C-4 么?怎么改了这么多文件?先从一个文件开始吧……

另外请注意提示信息 ⚠️提示⚠️ python/paddle/distributed 模块难度稍高,可先认领其他模块任务 🤟🤟🤟,先不要做分布式的……不然只会浪费彼此时间……

@lwkhahaha
Copy link
Contributor Author

截屏2024-08-01 10 42 57 想问一下老师这个报错该怎么解决

@lwkhahaha lwkhahaha changed the title [Typing][C-4] Add type annotations for python/paddle/distributed/auto_parallel/ interface.py distributed/auto_parallel/interface.py+strategy.py+placement_type.py and python/paddle/distributed/communication/group.py[Typing][C-4] Add type annotations for python/paddle/distributed/auto_parallel/ interface.py Aug 1, 2024
@lwkhahaha lwkhahaha changed the title distributed/auto_parallel/interface.py+strategy.py+placement_type.py and python/paddle/distributed/communication/group.py[Typing][C-4] Add type annotations for python/paddle/distributed/auto_parallel/ interface.py [Typing][C-4][C-7][C-9][C-18]Add type annotations for python/paddle/distributed/auto_parallel/interface.py+strategy.py+placement_type.py and python/paddle/distributed/communication/group.py Aug 1, 2024
@megemini
Copy link
Contributor

megemini commented Aug 4, 2024

@lwkhahaha C-4,C-7 先不用标了,可以恢复掉。

图中的错误是类型标注有问题,需要检查一下。

另外,PR 模板注意一下,不然 Tracking Issue 跟踪不到

Copy link

paddle-ci-bot bot commented Aug 7, 2024

Sorry to inform you that 1ab8a5d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@lwkhahaha lwkhahaha closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants