[Typing][C-50] Add type annotations for python/paddle/distributed/fleet/utils/ps_util.py
#66770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jul 30, 2024
| from paddle import Tensor | ||
| from paddle.base import Executor | ||
| from paddle.distributed.fleet.base.role_maker import RoleMakerBase | ||
| from paddle.framework import Program |
There was a problem hiding this comment.
Suggested change
| from paddle.framework import Program | |
| from paddle.static import Program |
paddle.framework.Program 不是公开 API，而且运行时有点细微差异，比如说 PIR 模式下并没有给 paddle.framework.Program patch 成 PIR 的 Program，虽然 patch 这种行为本身类型检查工具也不可能检查出来就是了……
|
|
||
| import paddle | ||
|
|
||
| if TYPE_CHECKING: | ||
| from paddle import Tensor | ||
| from paddle.base import Executor |
There was a problem hiding this comment.
Suggested change
| from paddle.base import Executor | |
| from paddle.static import Executor |
Lans1ot
pushed a commit
to Lans1ot/Paddle
that referenced
this pull request
Aug 5, 2024
…eet/utils/ps_util.py` (PaddlePaddle#66770) --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
python/paddle/distributed/fleet/utils/ps_util.pyRelated links
@SigureMo @megemini