【BUAA】【Infer Symbolic Shape No.90 92 2.8】Add CINN #66892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
uanu2002
changed the title
gongshaotian
reviewed
Aug 7, 2024
| @@ -124,7 +124,7 @@ def setUp(self): | |||
| self.convert_bf16() | |||
|
|
|||
| def test_check_output(self): | |||
| self.check_output(check_pir=True) | |||
gongshaotian
reviewed
Aug 7, 2024
| infer_context->GetShapeOrDataForValue(op->operand_source(0)).shape(); | ||
| std::vector<symbol::DimExpr> out_shape; | ||
| symbol::DimExpr out_unknown = | ||
| infer_context->GetNextSymName(); // unknown until runtime |
gongshaotian
reviewed
Aug 7, 2024
| op->attribute<pir::StrAttribute>("pooltype").AsString(); | ||
| if (pool_type == "MEAN") { | ||
| std::vector<symbol::DimExpr> summed_shape; | ||
| summed_shape.push_back(out_unknown); |
gongshaotian
reviewed
Aug 7, 2024
| bool SegmentPoolOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| const auto &input_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)).shape(); |
There was a problem hiding this comment.
判断一下data区有没有数据，有数据的话需要通过计算得到，不能再上新符号
|
randperm, segment_pool, set_value有对应optest单测。 |
| op->attribute<pir::StrAttribute>("pooltype").AsString(); | ||
|
|
||
| int ndims_ids = ids_shape.size(); | ||
| int last_dim = static_cast<int>(ids_shape[ndims_ids - 1].Get<std::int64_t>()); |
There was a problem hiding this comment.
这里应该是 ids_shape.size() - 1 吧
| if (ids_shape_or_data.data().has_value()) { | ||
| const auto &ids_data = ids_shape_or_data.data(); | ||
| int out_known = | ||
| static_cast<int>(ids_data.value()[last_dim - 1].Get<std::int64_t>()); |
There was a problem hiding this comment.
这个维度变换感觉写的有问题，应该是 out_shape.push_back(ids_data.value()[ids_shape.size() -1] + DimExpr{1})
看看编译没过
|
|
luotao1
approved these changes
Aug 13, 2024
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加 randperm, segment_pool, set_value 算子符号推导接口实现。