Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the unit test: test_semi_auto_llama_acc_align #66955

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix the unit test: test_semi_auto_llama_acc_align #66955

merged 1 commit into from
Aug 5, 2024
+10 −11

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Aug 2, 2024 •
edited
Loading

PR Category

Auto Parallel

PR Types

Bug fixes

Description

  • set “FLAGS_enable_pir_api=1” in test_semi_auto_llama_acc_align.py， and it will. take effect in PR-CI-Auto-Parallel.
  • fix inferspmd function error for reshape_grad.
  • remove the "execution_stream" attribute of all_gather op, which will lead to the communication group's mistake in executor.
  • fix the insert_point's prev funciton. which will cause segment fault while set op_role for the last op in the block.

Other

Pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 2, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the develop branch 2 times, most recently from e44789c to acccf4b Compare August 2, 2024 06:45
@winter-wang winter-wang changed the title fix bug in auto_parallel mode. fix the unit test: test_semi_auto_llama_acc_align Aug 2, 2024
JZ-LIANG
JZ-LIANG previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang merged commit fa40a78 into PaddlePaddle:develop Aug 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@JZ-LIANG JZ-LIANG JZ-LIANG left review comments

@LiYuRio LiYuRio Awaiting requested review from LiYuRio LiYuRio is a code owner

@ForFishes ForFishes Awaiting requested review from ForFishes ForFishes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winter-wang @zhiqiu @JZ-LIANG