Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-8] Add type annotations for python/paddle/distributed/auto_parallel/static/engine.py #66989

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

megemini
Copy link
Contributor

@megemini megemini commented Aug 4, 2024

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/distributed/auto_parallel/static/engine.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Aug 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

又是非公开 API 吧

@megemini
Copy link
Contributor Author

megemini commented Aug 4, 2024

LGTMeow 🐾

又是非公开 API 吧

🫠🫠🫠 又是导入了,没放到 __all__ 里面 ... ... 坑啊 ... ...

@SigureMo
Copy link
Member

SigureMo commented Aug 4, 2024

🫠🫠🫠 又是导入了,没放到 __all__ 里面 ... ... 坑啊 ... ...

非公开 API 暂时先别加吧,这个加了就加了,其他的加了之后他们维护不起来还得找过来,怪麻烦的……

@SigureMo SigureMo merged commit 2aa8398 into PaddlePaddle:develop Aug 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants