Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-111] Add type annotations for python/paddle/base/executor.py #66996

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Aug 4, 2024

PR Category

User Experience

PR Types

Improvements

Description

python/paddle/base/executor.py 中公开 API 标注类型

Related links

PCard-66972

Copy link

paddle-bot bot commented Aug 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo requested a review from zrr1999 August 4, 2024 18:06
@@ -41,7 +43,7 @@ def __init__(self):
"""Init."""
pass

def create_dataset(self, datafeed_class="QueueDataset"):
def create_dataset(self, datafeed_class="QueueDataset") -> DatasetBase:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datafeed_class 忘记标了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个返回值只是顺手加的,这个文件还没标注

@SigureMo SigureMo merged commit ba16a30 into PaddlePaddle:develop Aug 5, 2024
31 checks passed
@SigureMo SigureMo deleted the typing/c-111 branch August 5, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants