Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Fix PR template missing a whitespace #67000

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Aug 4, 2024

PR Category

Environment Adaptation

PR Types

Bug fixes

Description

修复 #66905 修改的模板和检查脚本不一致导致默认情况下 CheckPRTemplate 总是失败的问题,模板里最右多删了一个空格,与检查脚本里删掉注释的模板不匹配,所以这段注释总是不能被删掉,就会出现如下错误(https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/11253572/job/27101393):

ERROR MESSAGE: PR Category should be in ['User Experience', 'Execute Infrastructure', 'Operator Mechanism', 'CINN', 'Custom Device', 'Performance Optimization', 'Distributed Strategy', 'Parameter Server', 'Communication Library', 'Auto Parallel', 'Inference', 'Environment Adaptation']. but now is [<!-- one of [ user experience | execute infrastructure | operator mechanism | cinn | custom device | performance optimization | distributed strategy | parameter server | communication library | auto parallel | inference | environment adaptation] -->user experience.].

检测到的部分包含了没能删掉的注释 [<!-- one of [ user experience | execute infrastructure | operator mechanism | cinn | custom device | performance optimization | distributed strategy | parameter server | communication library | auto parallel | inference | environment adaptation] -->user experience.]

相关 PR 补充空格后通过

(其实这里的检查逻辑完全可以直接匹配所有注释并删掉的……)

PCard-66972

Copy link

paddle-bot bot commented Aug 4, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo requested a review from gouzil August 4, 2024 19:25
@gouzil gouzil merged commit 2aefa30 into PaddlePaddle:develop Aug 5, 2024
31 checks passed
@gouzil gouzil deleted the infra/fix-pr-template-missing-whitespace branch August 5, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants