【BUAA】【Infer Symbolic Shape】add set_value_with_tensor, sigmoid_cross_entropy_with_logits,swiglu #67098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
test_set_value_op.py, test_sigmoid_cross_entropy_with_logits_op.py,test_swiglu_op.py 中有对应optest单测, CI-Coverage 未覆盖位置并不是修改添加的op。 |
Comment on lines
775
to
781
| } else { | ||
| std::vector<symbol::DimExpr> x_shape = x_shape_or_data.shape(); | ||
| int x_last = static_cast<int>(x_shape[rank - 1].Get<std::int64_t>()); | ||
| infer_context->AddEqualCstr(symbol::DimExpr{x_last % 2}, | ||
| symbol::DimExpr{0}); | ||
| x_shape[rank - 1] = symbol::DimExpr{x_last / 2}; | ||
| infer_context->SetShapeOrDataForValue( |
There was a problem hiding this comment.
直接对DimExpr添加约束，取int就默认是静态shape了
| pos_shape_or_data.shape()[i]); | ||
| } | ||
| } | ||
| infer_context->SetShapeOrDataForValue(op->result(0), input_shape_or_data); |
There was a problem hiding this comment.
最好将Shape取出来单独设置，这里输入输出的data区应该不一样吧
Hongqing-work
approved these changes
Aug 12, 2024
Comment on lines
-102
to
+103
| // OP_DECLARE_INFER_SYMBOLIC_SHAPE(SetValueWithTensor) | ||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(SetValue) | ||
| OP_DECLARE_INFER_SYMBOLIC_SHAPE(SetValue_) |
There was a problem hiding this comment.
这个PR没有给set_value在yaml中加接口，下一个PR可以顺带加一下（或者给加set_value的同学说一声）
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…entropy_with_logits,swiglu (PaddlePaddle#67098)
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加set_value_with_tensor, sigmoid_cross_entropy_with_logits,swiglu算子符号推导接口实现。