Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typing][C-25,C-26] Add type annotations for python/paddle/distributed/communication/stream/{all_reduce,all_to_all}.py #67112

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[Typing][C-25,C-26] Add type annotations for python/paddle/distributed/communication/stream/{all_reduce,all_to_all}.py #67112

merged 2 commits into from
Aug 13, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Aug 7, 2024

PR Category

User Experience

PR Types

Improvements

Description

类型标注：

  • python/paddle/distributed/communication/stream/all_reduce.py
  • python/paddle/distributed/communication/stream/all_to_all.py

Related links

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 7, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 7, 2024
megemini
megemini reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

示例里面加个 ignore 吧，CI 提示有两个地方

>>> task.wait() # type: ignore[union-attr]

python/paddle/distributed/communication/stream/all_to_all.py Outdated Show resolved Hide resolved
@megemini megemini mentioned this pull request Aug 7, 2024
Closed
@paddle-bot paddle-bot bot added the contributor External developers label Aug 7, 2024
megemini
megemini approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

@megemini megemini mentioned this pull request Aug 12, 2024
Closed
@luotao1 luotao1 merged commit 1a12de0 into PaddlePaddle:develop Aug 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@megemini megemini megemini approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enkilee @luotao1 @megemini @SigureMo