[Typing][C-68,C-77][BUAA] Add type annotations for python/paddle/nn/* #67186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
老师想问一下这个报错该如何解决
|
megemini
reviewed
Aug 12, 2024
| quant_round_type: int = 1, | ||
| quant_max_bound: float = 127.0, | ||
| quant_min_bound: float = -127.0, | ||
| out_scale: Tensor = -1, |
There was a problem hiding this comment.
Suggested change
| out_scale: Tensor = -1, | |
| out_scale: float = -1, |
| quant_min_bound: float = -127.0, | ||
| out_scale: Tensor = -1, | ||
| compute_dtype: str = "default", | ||
| ) -> Tensor: |
There was a problem hiding this comment.
Suggested change
| ) -> Tensor: | |
| ) -> tuple[Tensor, Tensor, Tensor, Tensor]: |
Comment on lines
+437
to
+439
| out_scale: int = -1, | ||
| compute_dtype: str = "default", | ||
| ) -> Tensor: |
There was a problem hiding this comment.
CI 报错，需要编译选项，参考 https://github.com/PaddlePaddle/Paddle/pull/67178/files 在示例中添加
>>> # doctest: +SKIP('Need compile flash attention')
>>> # doctest: +REQUIRES(env:GPU)
Comment on lines
+53
to
+63
| dropout1_rate: float | None = 0.5, | ||
| dropout2_rate: float | None = 0.5, | ||
| activation: str | None = "relu", | ||
| ln1_epsilon: float | None = 1e-5, | ||
| ln2_epsilon: float | None = 1e-5, | ||
| pre_layer_norm: bool | None = False, | ||
| training: bool | None = True, | ||
| mode: str | None = 'upscale_in_train', | ||
| ring_id: int | None = -1, | ||
| add_residual: bool | None = True, | ||
| name: str | None = None, |
| ln2_epsilon: float | None = 1e-5, | ||
| pre_layer_norm: bool | None = False, | ||
| training: bool | None = True, | ||
| mode: str | None = 'upscale_in_train', |
Comment on lines
+336
to
+340
| dropout_rate: float | None = 0.5, | ||
| ln_epsilon: float | None = 1e-5, | ||
| training: bool | None = True, | ||
| mode: str | None = 'upscale_in_train', | ||
| name: str | None = None, |
Comment on lines
+523
to
+531
| dropout_rate: float | None = 0.5, | ||
| attn_dropout_rate: float | None = 0.5, | ||
| ln_epsilon: float | None = 1e-05, | ||
| training: bool | None = True, | ||
| mode: str | None = 'upscale_in_train', | ||
| ring_id: int | None = -1, | ||
| add_residual: bool | None = True, | ||
| num_heads: int | None = -1, | ||
| transpose_qkv_wb: bool | None = False, |
| @@ -962,41 +969,41 @@ def fused_multi_head_attention( | |||
|
|
|||
|
|
|||
| def fused_multi_transformer( | |||
There was a problem hiding this comment.
几个问题
list[Tensor]|tuple[Tensor]统一用Sequence[Tensor]- 默认值没有
None或者没有说明可以使用的，不要加None Literal的使用- 这个函数根据
cache_kvs的值需要使用overload
|
Sorry to inform you that 21229fd's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
SigureMo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
Add type annotations for python/paddle/nn/*