[Typing][PEP585 Upgrade][BUAA][131-150] Use standard collections for type hints for 19 files in test/
#67229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Whsjrczr
changed the title
SigureMo
changed the title
test/
SigureMo
reviewed
Aug 8, 2024
| @@ -14,7 +14,7 @@ | |||
|
|
|||
|
|
|||
| import math | |||
| from typing import Optional, Tuple | |||
| from typing import Optional | |||
| @@ -70,7 +70,7 @@ def generate_input1(dims, batch, attrs: List[Dict[str, Any]]): | |||
|
|
|||
| def sample_predictor_configs( | |||
| self, program_config | |||
| ) -> (paddle_infer.Config, List[int], float): | |||
| ) -> (paddle_infer.Config, list[int], float): | |||
There was a problem hiding this comment.
Suggested change
| ) -> (paddle_infer.Config, list[int], float): | |
| ) -> tuple[paddle_infer.Config, list[int], float]: |
这里是明显错误的，需要修改
别说一个就改一个，其他的也需要改
This was referenced Aug 9, 2024
SigureMo
approved these changes
Aug 9, 2024
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…type hints for 19 files in `test/` (PaddlePaddle#67229) --------- Co-authored-by: SigureMo <sigure.qaq@gmail.com>
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
修改了以下19个文件：
modified: test/auto_parallel/hybrid_strategy/semi_auto_parallel_llama_model.py
modified: test/deprecated/legacy_test/auto_parallel_op_test.py
modified: test/dygraph_to_static/test_dynamic_shape_infermeta.py
modified: test/dygraph_to_static/test_typehint.py
modified: test/dygraph_to_static/test_typing.py
modified: test/ipu/op_test_ipu.py
modified: test/ir/inference/auto_scan_test.py
modified: test/ir/inference/program_config.py
modified: test/ir/inference/test_trt_convert_activation.py
modified: test/ir/inference/test_trt_convert_affine_channel.py
modified: test/ir/inference/test_trt_convert_anchor_generator.py
modified: test/ir/inference/test_trt_convert_arg_max.py
modified: test/ir/inference/test_trt_convert_arg_min.py
modified: test/ir/inference/test_trt_convert_argsort.py
modified: test/ir/inference/test_trt_convert_assign.py
modified: test/ir/inference/test_trt_convert_batch_norm.py
modified: test/ir/inference/test_trt_convert_bilinear_interp_v2.py
modified: test/ir/inference/test_trt_convert_bitwise_and.py
modified: test/ir/inference/test_trt_convert_bitwise_not.py
注：test/dygraph_to_static/check_approval.py报错为U036