[Typing][C-81,C-102,C-103,C-105] Add type annotations for {fused_dropout_add,bfgs,lbfgs,math}.py in incubate APIs
#67233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
megemini
reviewed
Aug 9, 2024
| def __init__(self, p=0.5, mode="upscale_in_train", name=None): | ||
| def __init__( | ||
| self, | ||
| p: int = 0.5, |
| def __init__( | ||
| self, | ||
| p: int = 0.5, | ||
| mode: str = "upscale_in_train", |
| @@ -12,10 +12,17 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from __future__ import annotations | |||
|
|
|||
| from typing import TYPE_CHECKING, Callable | |||
There was a problem hiding this comment.
从 collections.abc 导入 Callable
| dtype='float32', | ||
| name=None, | ||
| ): | ||
| objective_func: Callable[[Tensor], float], |
There was a problem hiding this comment.
Suggested change
| objective_func: Callable[[Tensor], float], | |
| objective_func: Callable[[Tensor], Tensor], |
应该是个标量形式的 Tensor ，具体类型还是 Tensor
| tolerance_grad: float = 1e-7, | ||
| tolerance_change: float = 1e-9, | ||
| initial_inverse_hessian_estimate: Tensor | None = None, | ||
| line_search_fn: str = 'strong_wolfe', |
| line_search_fn: str = 'strong_wolfe', | ||
| max_line_search_iters: int = 50, | ||
| initial_step_length: float = 1.0, | ||
| dtype: str = 'float32', |
| @@ -12,6 +12,13 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from __future__ import annotations | |||
|
|
|||
| from typing import TYPE_CHECKING, Callable | |||
Comment on lines
35
to
47
| objective_func: Callable[[Tensor], float], | ||
| initial_position: Tensor, | ||
| history_size: int = 100, | ||
| max_iters: int = 50, | ||
| tolerance_grad: float = 1e-8, | ||
| tolerance_change: float = 1e-8, | ||
| initial_inverse_hessian_estimate: Tensor | None = None, | ||
| line_search_fn: str = 'strong_wolfe', | ||
| max_line_search_iters: int = 50, | ||
| initial_step_length: int = 1.0, | ||
| dtype: str = 'float32', | ||
| name: str | None = None, | ||
| ) -> tuple[bool, int, Tensor, Tensor, Tensor]: |
megemini
reviewed
Aug 9, 2024
| tolerance_grad: float = 1e-7, | ||
| tolerance_change: float = 1e-9, | ||
| initial_inverse_hessian_estimate: Tensor | None = None, | ||
| line_search_fn: Literal['strong wolfe', 'Hager Zhang'] = 'strong_wolfe', |
There was a problem hiding this comment.
Suggested change
| line_search_fn: Literal['strong wolfe', 'Hager Zhang'] = 'strong_wolfe', | |
| line_search_fn: Literal['strong_wolfe'] = 'strong_wolfe', |
| tolerance_grad: float = 1e-8, | ||
| tolerance_change: float = 1e-8, | ||
| initial_inverse_hessian_estimate: Tensor | None = None, | ||
| line_search_fn: Literal['strong wolfe', 'Hager Zhang'] = 'strong wolfe', |
There was a problem hiding this comment.
Suggested change
| line_search_fn: Literal['strong wolfe', 'Hager Zhang'] = 'strong wolfe', | |
| line_search_fn: Literal['strong_wolfe'] = 'strong_wolfe', |
megemini
reviewed
Aug 12, 2024
| tolerance_grad: float = 1e-7, | ||
| tolerance_change: float = 1e-9, | ||
| initial_inverse_hessian_estimate: Tensor | None = None, | ||
| line_search_fn: Literal['strong wolfe'] = 'strong_wolfe', |
SigureMo
reviewed
Aug 12, 2024
Comment on lines
19
to
20
| if TYPE_CHECKING: | ||
| from paddle import Tensor |
There was a problem hiding this comment.
不要将 if TYPE_CHECKING: 块插在其它 import 中间
放在 23 行后
| import numpy as np | ||
|
|
||
| import paddle | ||
|
|
||
| if TYPE_CHECKING: |
|
|
||
| from typing import TYPE_CHECKING, Literal | ||
|
|
||
| if TYPE_CHECKING: |
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: |
SigureMo
changed the title
fused_dropout_add.py, bfgs.py, lbfgs.py math.py{fused_dropout_add,bfgs,lbfgs,math}.py
SigureMo
changed the title
{fused_dropout_add,bfgs,lbfgs,math}.py{fused_dropout_add,bfgs,lbfgs,math}.py for incubate APIs
SigureMo
changed the title
{fused_dropout_add,bfgs,lbfgs,math}.py for incubate APIs{fused_dropout_add,bfgs,lbfgs,math}.py in incubate APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
#65008
尝试添加函数类型信息
但有一个问题，scalar该如何标注，我这里是用的float。