Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Infer Symbolic Shape No.122】【BUAA】Add batch_fc #67348

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

Whsjrczr
Copy link
Contributor

PR Category

CINN

PR Types

Others

Description

Add BatchFcOpInferSymbolicShape

Copy link

paddle-bot bot commented Aug 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 12, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 13, 2024
Comment on lines 252 to 269
PADDLE_ENFORCE_EQ(
input_dims[0],
w_dims[0],
common::errors::InvalidArgument(
"Input.dim[0] and W.dim[0] of BatchFcOp should be same."));
PADDLE_ENFORCE_EQ(
input_dims[2],
w_dims[1],
common::errors::InvalidArgument(
"Input.dim[2] and W.dim[1] of BatchFcOp should be same."));
PADDLE_ENFORCE_EQ(bias_dims[0],
input_dims[0],
common::errors::InvalidArgument(
"Bias.dim[0] should be same as input.dim[0]."));
PADDLE_ENFORCE_EQ(bias_dims[1],
w_dims[2],
common::errors::InvalidArgument(
"Bias.dim[1] should be same as input.dim[2]."));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改为添加约束

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

Copy link
Contributor

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Whsjrczr
Copy link
Contributor Author

截屏2024-08-16 10 02 14 单测存在,pir测试未打开

@luotao1 luotao1 merged commit 2a26f80 into PaddlePaddle:develop Aug 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants